Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: split Algebra.CharP.Basic, reduce imports in RingTheory.Multiplicity #8637

Closed
wants to merge 4 commits into from

Conversation

semorrison
Copy link
Contributor

This was adding unnecessary imports to Data.ZMod.Basic.


Despite adding several files, this reduces the total number of transitive imports reported via:

import Mathlib

open Lean Meta
#eval show MetaM Nat from do
  let mut t := 0
  for (_, s) in (← getEnv).importGraph.transitiveClosure do
    t := t + s.size
  return t

(only by about 600 out of 5.3m, but it's a start :-)

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Nov 27, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 4, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2023
…licity (#8637)

This was adding unnecessary imports to `Data.ZMod.Basic`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 4, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: split Algebra.CharP.Basic, reduce imports in RingTheory.Multiplicity [Merged by Bors] - chore: split Algebra.CharP.Basic, reduce imports in RingTheory.Multiplicity Dec 4, 2023
@mathlib-bors mathlib-bors bot closed this Dec 4, 2023
@mathlib-bors mathlib-bors bot deleted the imports_charp branch December 4, 2023 08:33
awueth pushed a commit that referenced this pull request Dec 19, 2023
…licity (#8637)

This was adding unnecessary imports to `Data.ZMod.Basic`.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants