Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Add API for AlgEquiv. #8639

Closed
wants to merge 17 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Nov 27, 2023


Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 27, 2023
lemma one_toLinearMap :
(1 : A₁ ≃ₐ[R] A₁).toLinearMap = 1 := rfl

/-- The units group of `S →ₐ[R] S` is `S ≃ₐ[R] S` -/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a cross-reference to the LinearEquiv version we already have?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean LinearMap.GeneralLinearGroup.generalLinearEquiv?

Copy link
Member

@eric-wieser eric-wieser Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly! In fact, it might be nice to show that (algHomUnitsEquiv.symm f).map (toLinearMapHom R A) = (LinearMap.GeneralLinearGroup.generalLinearEquiv.symm f.toLinearMap) or similar

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure where such a lemma should go though, and I don't think this lemma is useful enough to warrant a new file of its own.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I hadn't realized there was an import issue. That sounds fair.

@erdOne erdOne added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Nov 27, 2023
@erdOne erdOne added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 28, 2023
(σ ^ n).toLinearMap = σ.toLinearMap ^ n :=
(AlgEquiv.toLinearMapHom R A₁).map_pow σ n

lemma one_toLinearMap :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma one_toLinearMap :
@[simp] lemma one_toLinearMap :

Comment on lines +793 to +795
lemma pow_toLinearMap (σ : A₁ ≃ₐ[R] A₁) (n : ℕ) :
(σ ^ n).toLinearMap = σ.toLinearMap ^ n :=
(AlgEquiv.toLinearMapHom R A₁).map_pow σ n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the zpow version too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no zpow on linear maps.

@eric-wieser
Copy link
Member

bors d+

Thanks!

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 30, 2023

✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@eric-wieser eric-wieser added the t-algebra Algebra (groups, rings, fields etc) label Nov 30, 2023
@erdOne
Copy link
Member Author

erdOne commented Dec 5, 2023

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 5, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 5, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Add API for AlgEquiv. [Merged by Bors] - feat: Add API for AlgEquiv. Dec 5, 2023
@mathlib-bors mathlib-bors bot closed this Dec 5, 2023
@mathlib-bors mathlib-bors bot deleted the erd1/algequiv_lemmas branch December 5, 2023 20:07
awueth pushed a commit that referenced this pull request Dec 19, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants