-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: Add API for AlgEquiv
.
#8639
Conversation
erdOne
commented
Nov 27, 2023
…lib4 into erd1/algequiv_lemmas
Mathlib/Algebra/Algebra/Equiv.lean
Outdated
lemma one_toLinearMap : | ||
(1 : A₁ ≃ₐ[R] A₁).toLinearMap = 1 := rfl | ||
|
||
/-- The units group of `S →ₐ[R] S` is `S ≃ₐ[R] S` -/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a cross-reference to the LinearEquiv
version we already have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean LinearMap.GeneralLinearGroup.generalLinearEquiv
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly! In fact, it might be nice to show that (algHomUnitsEquiv.symm f).map (toLinearMapHom R A) = (LinearMap.GeneralLinearGroup.generalLinearEquiv.symm f.toLinearMap)
or similar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where such a lemma should go though, and I don't think this lemma is useful enough to warrant a new file of its own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I hadn't realized there was an import issue. That sounds fair.
(σ ^ n).toLinearMap = σ.toLinearMap ^ n := | ||
(AlgEquiv.toLinearMapHom R A₁).map_pow σ n | ||
|
||
lemma one_toLinearMap : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lemma one_toLinearMap : | |
@[simp] lemma one_toLinearMap : |
lemma pow_toLinearMap (σ : A₁ ≃ₐ[R] A₁) (n : ℕ) : | ||
(σ ^ n).toLinearMap = σ.toLinearMap ^ n := | ||
(AlgEquiv.toLinearMapHom R A₁).map_pow σ n |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the zpow
version too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no zpow on linear maps.
bors d+ Thanks! |
✌️ erdOne can now approve this pull request. To approve and merge a pull request, simply reply with |
bors merge |
Pull request successfully merged into master. Build succeeded: |
AlgEquiv
.AlgEquiv
.