[Merged by Bors] - feat: remove an assumption #8646
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
added
awaiting-review
YaelDillies
reviewed
Nov 27, 2023
| @@ -730,7 +730,8 @@ lemma finEquivZpowers_apply (hx) {n : Fin (orderOf x)} : | |||
|
|
|||
| -- This lemma has always been bad, but the linter only noticed after leaprover/lean4#2644. | |||
| @[to_additive (attr := simp, nolint simpNF) finEquivZmultiples_symm_apply] | |||
| lemma finEquivZpowers_symm_apply (x : G) (hx) (n : ℕ) {hn : ∃ m : ℤ, x ^ m = x ^ n} : | |||
| lemma finEquivZpowers_symm_apply (x : G) (hx) (n : ℕ) : | |||
| letI hn : ∃ m : ℤ, x ^ m = x ^ n := ⟨n, by simp⟩ | |||
There was a problem hiding this comment.
Suggested change
| letI hn : ∃ m : ℤ, x ^ m = x ^ n := ⟨n, by simp⟩ | |
| letI hn : ∃ m : ℤ, x ^ m = x ^ n := ⟨n, rfl⟩ |
Can you not even inline it at this point?
There was a problem hiding this comment.
rfl doesn't work here, but inlining is a good idea.
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
The assumption `hn` in [finEquivZpowers_symm_apply](https://leanprover-community.github.io/mathlib4_docs/Mathlib/GroupTheory/OrderOfElement.html#finEquivZpowers_symm_apply) always holds.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
The assumption `hn` in [finEquivZpowers_symm_apply](https://leanprover-community.github.io/mathlib4_docs/Mathlib/GroupTheory/OrderOfElement.html#finEquivZpowers_symm_apply) always holds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The assumption
hnin finEquivZpowers_symm_apply always holds.