Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(GroupTheory/SpecificGroups/Cyclic): Add non-cyclic -> nontrivial #8693

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(GroupTheory/SpecificGroups/Cyclic): Add non-cyclic -> nontrivial #8693

wants to merge 3 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Nov 28, 2023

A non-cyclic group is also non-trivial, whether it is multiplicative or additive.

Open in Gitpod

@adomani adomani added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Nov 28, 2023
@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Nov 29, 2023
adomani and others added 2 commits November 29, 2023 06:34
@adomani @urkud
Apply Yuri's suggestions
9efddbb 
Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@adomani
Update to_additive name and doc-strings
da669fc
@adomani adomani added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Nov 29, 2023
@urkud
Copy link
Member

urkud commented Nov 29, 2023

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 29, 2023
mathlib-bors bot pushed a commit that referenced this pull request Nov 29, 2023
@adomani
feat(GroupTheory/SpecificGroups/Cyclic): Add non-cyclic -> nontrivial (…
63c5a7e 
…#8693)

A non-cyclic group is also non-trivial, whether it is multiplicative or additive.
@mathlib-bors
Copy link

mathlib-bors bot commented Nov 29, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(GroupTheory/SpecificGroups/Cyclic): Add non-cyclic -> nontrivial [Merged by Bors] - feat(GroupTheory/SpecificGroups/Cyclic): Add non-cyclic -> nontrivial Nov 29, 2023
@mathlib-bors mathlib-bors bot closed this Nov 29, 2023
@mathlib-bors mathlib-bors bot deleted the adomani/noncyclic_nontrivial branch November 29, 2023 07:55
awueth pushed a commit that referenced this pull request Dec 19, 2023
@adomani @awueth
feat(GroupTheory/SpecificGroups/Cyclic): Add non-cyclic -> nontrivial (…
940fa0e 
…#8693)

A non-cyclic group is also non-trivial, whether it is multiplicative or additive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adomani @urkud