New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(Data/Finset/NatDivisors): Nat.divisors of a product #8695
Conversation
I golfed your proof. I'm not sure that you need more imports for the new proof. Also, you can get a slightly different version of lemma Prime.divisors_sq {p : ℕ} (hp : p.Prime) : (p ^ 2).divisors = {p ^ 2, p, 1} := by
simp [divisors_prime_pow hp, range_succ] I'm not sure that we have a nice way to reorder a chain of Also, I think that it would be nice to have a version for |
Yuri, I added the Thanks! |
Yuri, I added the Anyway, I could still not move the lemmas in a different file, since I could not find any interaction between From this point of view, it may make sense to create this new file, what do you think? |
Yuri, your latest commit is such an improvement over my butchering of the lemmas! Thanks! |
Thanks! 🎉 |
The function `Nat.divisors` as a multiplicative homomorphism `ℕ →* Finset ℕ`. This result is in a new file `Data/Finset/NatDivisors`, to avoid adding imports and/or lengthening existing files. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
Pull request successfully merged into master. Build succeeded: |
The function `Nat.divisors` as a multiplicative homomorphism `ℕ →* Finset ℕ`. This result is in a new file `Data/Finset/NatDivisors`, to avoid adding imports and/or lengthening existing files. Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
The function
Nat.divisors
as a multiplicative homomorphismℕ →* Finset ℕ
.This result is in a new file
Data/Finset/NatDivisors
, to avoid adding imports and/or lengthening existing files.