Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Algebra.EuclideanDomain.Defs #871

Closed
wants to merge 12 commits into from

Conversation

zeramorphic
Copy link
Collaborator

mathlib3 SHA: f1a2caaf51ef593799107fe9a8d5e411599f3996

Signed-off-by: zeramorphic <zeramorphic@proton.me>
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic zeramorphic added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Dec 6, 2022
Signed-off-by: zeramorphic <zeramorphic@proton.me>
Signed-off-by: zeramorphic <zeramorphic@proton.me>
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic
Copy link
Collaborator Author

The unusedHavesSuffices linter flags xgcd_zero_left and xgcd_aux_rec, but I think these are false positives for unfolding xgcd_aux.

@zeramorphic zeramorphic added the help-wanted The author needs attention to resolve issues label Dec 6, 2022
Signed-off-by: zeramorphic <zeramorphic@proton.me>
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
zeramorphic and others added 3 commits December 6, 2022 13:28
Signed-off-by: zeramorphic <zeramorphic@proton.me>
Signed-off-by: zeramorphic <zeramorphic@proton.me>
@zeramorphic zeramorphic added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues WIP Work in progress labels Dec 7, 2022
@zeramorphic zeramorphic marked this pull request as ready for review December 7, 2022 16:38
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/EuclideanDomain/Defs.lean Outdated Show resolved Hide resolved
zeramorphic and others added 3 commits December 7, 2022 16:45
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 7, 2022
bors bot pushed a commit that referenced this pull request Dec 7, 2022
mathlib3 SHA: f1a2caaf51ef593799107fe9a8d5e411599f3996

Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: zeramorphic <50671761+zeramorphic@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented Dec 7, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.EuclideanDomain.Defs [Merged by Bors] - feat: port Algebra.EuclideanDomain.Defs Dec 7, 2022
@bors bors bot closed this Dec 7, 2022
@bors bors bot deleted the Algebra.EuclideanDomain.Defs branch December 7, 2022 23:14
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Dec 8, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.euclidean_domain.defs`: leanprover-community/mathlib4#871
* `algebra.group.ext`: leanprover-community/mathlib4#850
* `algebra.group_power.basic`: leanprover-community/mathlib4#874
* `algebra.hom.equiv.units.basic`: leanprover-community/mathlib4#895
* `algebra.hom.equiv.units.group_with_zero`: leanprover-community/mathlib4#901
* `algebra.order.group.instances`: leanprover-community/mathlib4#890
* `algebra.order.group.order_iso`: leanprover-community/mathlib4#895
* `algebra.order.group.units`: leanprover-community/mathlib4#898
* `algebra.order.monoid.nat_cast`: leanprover-community/mathlib4#893
* `algebra.order.monoid.type_tags`: leanprover-community/mathlib4#873
* `algebra.order.monoid.units`: leanprover-community/mathlib4#873
* `algebra.order.zero_le_one`: leanprover-community/mathlib4#893
* `combinatorics.quiver.push`: leanprover-community/mathlib4#868
* `control.traversable.basic`: leanprover-community/mathlib4#788
* `data.sum.order`: leanprover-community/mathlib4#880
* `group_theory.group_action.option`: leanprover-community/mathlib4#884
* `group_theory.group_action.sigma`: leanprover-community/mathlib4#885
* `group_theory.group_action.sum`: leanprover-community/mathlib4#882
* `group_theory.group_action.units`: leanprover-community/mathlib4#878
* `order.antisymmetrization`: leanprover-community/mathlib4#876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants