[Merged by Bors] - feat: two isomorphic number fields have the same discriminant #8714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xroblot
commented
Nov 29, 2023
xroblot
commented
xroblot
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
xroblot
added
awaiting-CI
t-number-theory
xroblot
added
the
awaiting-review
|
✌️ xroblot can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors r+ |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
alreadydone
added a commit
that referenced
this pull request
Dec 11, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
+ generalize `image_rootSet`, `adjoin_rootSet_eq_range` and `splits_comp_of_splits` in Data/Polynomial/Splits and use the last one to golf `splits_of_algHom`, `splits_of_isScalarTower` (introduced in # 8609). + add three new lemmas `mem_range_x_of_minpoly_splits` to simplify the construction of `IntermediateField.algHomEquivAlgHomOfIsAlgClosed` and `Algebra.IsAlgebraic.algHomEquivAlgHomOfIsAlgClosed`, remove the `IsAlgClosed` condition and rename. ~~They could be moved to an earlier file but I refrain from doing that. (#find_home says it's already in the right place)~~ + golf `primitive_element_iff_algHom_eq_of_eval` from # 8609, using a new lemma `IsIntegral.minpoly_splits_tower_top` for the last step. + make `integralClosure_algEquiv_restrict` (from # 8714) computable and rename to `AlgEquiv.mapIntegralClosure` to follow camelCase naming convention and enable dot notation. Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
+ generalize `image_rootSet`, `adjoin_rootSet_eq_range` and `splits_comp_of_splits` in Data/Polynomial/Splits and use the last one to golf `splits_of_algHom`, `splits_of_isScalarTower` (introduced in # 8609). + add three new lemmas `mem_range_x_of_minpoly_splits` to simplify the construction of `IntermediateField.algHomEquivAlgHomOfIsAlgClosed` and `Algebra.IsAlgebraic.algHomEquivAlgHomOfIsAlgClosed`, remove the `IsAlgClosed` condition and rename. ~~They could be moved to an earlier file but I refrain from doing that. (#find_home says it's already in the right place)~~ + golf `primitive_element_iff_algHom_eq_of_eval` from # 8609, using a new lemma `IsIntegral.minpoly_splits_tower_top` for the last step. + make `integralClosure_algEquiv_restrict` (from # 8714) computable and rename to `AlgEquiv.mapIntegralClosure` to follow camelCase naming convention and enable dot notation. Co-authored-by: Xavier-François Roblot <46200072+xroblot@users.noreply.github.com> Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.