[Merged by Bors] - chore: rename most lemmas involving clopen to isClopen #8720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
awaiting-review
|
Please list all theorems you renamed in the commit message (e.g., grep the diff for
What name do you suggest? |
|
Otherwise LGTM. Thanks! |
|
✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
DiscreteQuotient.ofClopen -> DiscreteQuotient.ofIsClopen LocallyConstant.ofClopen -> LocallyConstant.ofIsClopen LocallyConstant.ofClopen_fiber_one -> LocallyConstant.ofIsClopen_fiber_one LocallyConstant.ofClopen_fiber_zero -> LocallyConstant.ofIsClopen_fiber_zero
|
I went for ofIsClopen (also in LocallyConstant and a few similar ones). Thanks for the fast review! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
This PR renames the field Clopens.clopen' -> Clopens.isClopen', and the lemmas
* preimage_closed_of_closed -> ContinuousOn.preimage_isClosed_of_isClosed
as well as:
ClopenUpperSet.clopen -> ClopenUpperSet.isClopen
connectedComponent_eq_iInter_clopen -> connectedComponent_eq_iInter_isClopen
connectedComponent_subset_iInter_clopen -> connectedComponent_subset_iInter_isClopen
continuous_boolIndicator_iff_clopen -> continuous_boolIndicator_iff_isClopen
continuousOn_boolIndicator_iff_clopen -> continuousOn_boolIndicator_iff_isClopen
DiscreteQuotient.ofClopen -> DiscreteQuotient.ofIsClopen
disjoint_or_subset_of_clopen -> disjoint_or_subset_of_isClopen
exists_clopen_{lower,upper}_of_not_le -> exists_isClopen_{lower,upper}_of_not_le
exists_clopen_of_cofiltered -> exists_isClopen_of_cofiltered
exists_clopen_of_totally_separated -> exists_isClopen_of_totally_separated
exists_clopen_upper_or_lower_of_ne -> exists_isClopen_upper_or_lower_of_ne
IsPreconnected.subset_clopen -> IsPreconnected.subset_isClopen
isTotallyDisconnected_of_clopen_set -> isTotallyDisconnected_of_isClopen_set
LocallyConstant.ofClopen_fiber_one -> LocallyConstant.ofIsClopen_fiber_one
LocallyConstant.ofClopen_fiber_zero -> LocallyConstant.ofIsClopen_fiber_zero
LocallyConstant.ofClopen -> LocallyConstant.ofIsClopen
preimage_clopen_of_clopen -> preimage_isClopen_of_isClopen
TopologicalSpace.Clopens.clopen -> TopologicalSpace.Clopens.isClopen
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
This PR renames the field Clopens.clopen' -> Clopens.isClopen', and the lemmas
* preimage_closed_of_closed -> ContinuousOn.preimage_isClosed_of_isClosed
as well as:
ClopenUpperSet.clopen -> ClopenUpperSet.isClopen
connectedComponent_eq_iInter_clopen -> connectedComponent_eq_iInter_isClopen
connectedComponent_subset_iInter_clopen -> connectedComponent_subset_iInter_isClopen
continuous_boolIndicator_iff_clopen -> continuous_boolIndicator_iff_isClopen
continuousOn_boolIndicator_iff_clopen -> continuousOn_boolIndicator_iff_isClopen
DiscreteQuotient.ofClopen -> DiscreteQuotient.ofIsClopen
disjoint_or_subset_of_clopen -> disjoint_or_subset_of_isClopen
exists_clopen_{lower,upper}_of_not_le -> exists_isClopen_{lower,upper}_of_not_le
exists_clopen_of_cofiltered -> exists_isClopen_of_cofiltered
exists_clopen_of_totally_separated -> exists_isClopen_of_totally_separated
exists_clopen_upper_or_lower_of_ne -> exists_isClopen_upper_or_lower_of_ne
IsPreconnected.subset_clopen -> IsPreconnected.subset_isClopen
isTotallyDisconnected_of_clopen_set -> isTotallyDisconnected_of_isClopen_set
LocallyConstant.ofClopen_fiber_one -> LocallyConstant.ofIsClopen_fiber_one
LocallyConstant.ofClopen_fiber_zero -> LocallyConstant.ofIsClopen_fiber_zero
LocallyConstant.ofClopen -> LocallyConstant.ofIsClopen
preimage_clopen_of_clopen -> preimage_isClopen_of_isClopen
TopologicalSpace.Clopens.clopen -> TopologicalSpace.Clopens.isClopen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the field Clopens.clopen' -> Clopens.isClopen', and the lemmas
as well as:
ClopenUpperSet.clopen -> ClopenUpperSet.isClopen
connectedComponent_eq_iInter_clopen -> connectedComponent_eq_iInter_isClopen
connectedComponent_subset_iInter_clopen -> connectedComponent_subset_iInter_isClopen
continuous_boolIndicator_iff_clopen -> continuous_boolIndicator_iff_isClopen
continuousOn_boolIndicator_iff_clopen -> continuousOn_boolIndicator_iff_isClopen
DiscreteQuotient.ofClopen -> DiscreteQuotient.ofIsClopen
disjoint_or_subset_of_clopen -> disjoint_or_subset_of_isClopen
exists_clopen_{lower,upper}of_not_le -> exists_isClopen{lower,upper}_of_not_le
exists_clopen_of_cofiltered -> exists_isClopen_of_cofiltered
exists_clopen_of_totally_separated -> exists_isClopen_of_totally_separated
exists_clopen_upper_or_lower_of_ne -> exists_isClopen_upper_or_lower_of_ne
IsPreconnected.subset_clopen -> IsPreconnected.subset_isClopen
isTotallyDisconnected_of_clopen_set -> isTotallyDisconnected_of_isClopen_set
LocallyConstant.ofClopen_fiber_one -> LocallyConstant.ofIsClopen_fiber_one
LocallyConstant.ofClopen_fiber_zero -> LocallyConstant.ofIsClopen_fiber_zero
LocallyConstant.ofClopen -> LocallyConstant.ofIsClopen
preimage_clopen_of_clopen -> preimage_isClopen_of_isClopen
TopologicalSpace.Clopens.clopen -> TopologicalSpace.Clopens.isClopen
This leaves a hand-ful of remaining lemmas, for the next person to stumble upon this.