[Merged by Bors] - feat(to_additive + Cyclic): auto cyclic --> addCyclic
#8722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adomani
added
the
awaiting-review
|
Thanks! maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
|
Thanks! |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Teach the conversion `Cyclic ↦ addCyclic` to `to_additive`. Affected files: ```bash GroupTheory/SpecificGroups/Cyclic Tactic/ToAdditive ```
eric-wieser
changed the title
Cyclic --> addCycliccyclic --> addCyclic
|
@adomani, is there a reason you've taken to listing the affected files in the commit message? This is tracked automatically by git, so seems redundant (and therefore at risk of being wrong) to me. |
|
Eric, I removed the affected files in this PR. I have a script that creates (a template for) the commit message and had it in there. I'll get rid of it! |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
cyclic --> addCycliccyclic --> addCyclic
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Teach the conversion `Cyclic ↦ addCyclic` to `to_additive`. Affected files: ```bash GroupTheory/SpecificGroups/Cyclic Tactic/ToAdditive ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Teach the conversion
Cyclic ↦ addCyclictoto_additive.