[Merged by Bors] - feat(Algebra/Group/Hom/Instances): missing instances on AddMonoid.End
#8741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
1 task
fpvandoorn
reviewed
Nov 30, 2023
Mathlib/Algebra/Module/Hom.lean
Outdated
| /-- The tautological action by `AddMonoid.End α` on `α`. | ||
|
|
||
| This generalizes `AddMonoid.End.applyDistribMulAction`. -/ | ||
| instance AddMonoid.End.applyModule [AddCommMonoid A] : Module (AddMonoid.End A) A where |
There was a problem hiding this comment.
put this above the end AddMonoid.End a few lines higher?
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
…d` (#8741) We already had these instance for `AddMonoidHom`, but did not copy them across. This also corrects some instances names, both for cosmetic reasons, and to avoid name clashes.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
AddMonoid.EndAddMonoid.End
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…d` (#8741) We already had these instance for `AddMonoidHom`, but did not copy them across. This also corrects some instances names, both for cosmetic reasons, and to avoid name clashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already had these instance for
AddMonoidHom, but did not copy them across.This also corrects some instances names, both for cosmetic reasons, and to avoid name clashes.