Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum #8787

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum #8787

wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label Dec 2, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 2, 2023
@Ruben-VandeVelde Ruben-VandeVelde removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 3, 2023
jcommelin
jcommelin approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 4, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2023
@Ruben-VandeVelde
chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum (#8787
b7b7d75 
)
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 4, 2023

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2023
@Ruben-VandeVelde
chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum (#8787
aca3f23 
)
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 4, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum [Merged by Bors] - chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum Dec 4, 2023
@mathlib-bors mathlib-bors bot closed this Dec 4, 2023
@mathlib-bors mathlib-bors bot deleted the map_prod branch December 4, 2023 12:41
awueth pushed a commit that referenced this pull request Dec 19, 2023
@Ruben-VandeVelde @awueth
chore: remove deprecated MonoidHom.map_prod, AddMonoidHom.map_sum (#8787
d8402ff 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @jcommelin @leanprover-community-mathlib4-bot