Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: rename by_contra' to by_contra! #8797

Closed
wants to merge 4 commits into from

Conversation

semorrison
Copy link
Contributor

To fit with the "please try harder" convention of ! tactics.


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Dec 3, 2023
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It always surprised me this wasn't the name in the first place.

maintainer merge

Copy link

github-actions bot commented Dec 3, 2023

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@sgouezel
Copy link
Contributor

sgouezel commented Dec 3, 2023

bors d+
It will conflict with #8798, so please wait until this one is merged and merge master and fix before sending it to bors.

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 3, 2023

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 3, 2023
@semorrison
Copy link
Contributor Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 3, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 3, 2023
To fit with the "please try harder" convention of `!` tactics.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 3, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: rename by_contra' to by_contra! [Merged by Bors] - chore: rename by_contra' to by_contra! Dec 3, 2023
@mathlib-bors mathlib-bors bot closed this Dec 3, 2023
@mathlib-bors mathlib-bors bot deleted the rename_by_contra branch December 3, 2023 14:06
awueth pushed a commit that referenced this pull request Dec 19, 2023
To fit with the "please try harder" convention of `!` tactics.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants