Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Dual basis of power basis wrt trace form #8835

Closed
wants to merge 15 commits into from

Conversation

erdOne
Copy link
Member

@erdOne erdOne commented Dec 6, 2023


Open in Gitpod

@erdOne erdOne added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 7, 2023
@riccardobrasca riccardobrasca self-assigned this Dec 8, 2023
Mathlib/Data/Polynomial/RingDivision.lean Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
@riccardobrasca
Copy link
Member

It looks still good to me, thanks!

bors merge

@riccardobrasca
Copy link
Member

bors r-

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 11, 2023

Canceled.

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 11, 2023
@riccardobrasca
Copy link
Member

Sorry, I was working on another PR and I switched tab.

@erdOne erdOne added awaiting-review The author would like community review of the PR and removed ready-to-merge This PR has been sent to bors. labels Dec 12, 2023
Mathlib.lean Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 14, 2023
@riccardobrasca
Copy link
Member

Can you please fix the conflict?

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 14, 2023
Mathlib/RingTheory/IntegralClosure.lean Show resolved Hide resolved
Mathlib/FieldTheory/Minpoly/MinpolyDiv.lean Outdated Show resolved Hide resolved
erdOne and others added 2 commits December 15, 2023 05:44
Co-authored-by: Riccardo Brasca <riccardo.brasca@gmail.com>
Comment on lines +135 to +137
lemma coeff_minpolyDiv_sub_pow_mem_span {i} (hi : i ≤ natDegree (minpolyDiv R x)) :
coeff (minpolyDiv R x) (natDegree (minpolyDiv R x) - i) - x ^ i ∈
Submodule.span R ((x ^ ·) '' Set.Iio i) := by
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #9071 which may make some lemmas easier, including this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I failed to use them to make the proofs shorter.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try later. I think several lemmas could be easier using what we know about divByMonic, instead of using the characterization you introduced.

I've started wondering whether we should prove something general about upper/lower triangular matrices (with 1 on the diagonal) or such linear systems ... but #9071 was merged really quickly (thanks!)
Edit: sorry there's probably nothing general. It's about the inverse of a particular type of bidiagonal matrix. There exists a general formula for the inverse of bidiagonal matrices, but it's probably too complicated for the use case here.

It might help to prove the stronger statement that the submodule spanned by the first i coefficients is equal to that spanned by the first i powers of x.

@erdOne
Copy link
Member Author

erdOne commented Dec 17, 2023

What's the status of this PR? I suggest we merge it first and golf it later as the proofs are already not that long.

@riccardobrasca
Copy link
Member

I agree, we can golf it later. Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 17, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 17, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 17, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Dual basis of power basis wrt trace form [Merged by Bors] - feat: Dual basis of power basis wrt trace form Dec 17, 2023
@mathlib-bors mathlib-bors bot closed this Dec 17, 2023
@mathlib-bors mathlib-bors bot deleted the erd1/minpolyDiv branch December 17, 2023 20:09
awueth pushed a commit that referenced this pull request Dec 19, 2023
Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants