Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: When Finsupp.prod is nonzero #8844

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: When Finsupp.prod is nonzero #8844

wants to merge 7 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Also replace Finsupp.nonzero_iff_exists by a more general lemma.

Open in Gitpod

@YaelDillies
feat: When Finsupp.prod is nonzero
ecf8865 
Also replace `Finsupp.nonzero_iff_exists` by a more general lemma.
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 6, 2023
eric-wieser
eric-wieser reviewed Dec 6, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if these lemma are consistent with DFinsupp, and if not, adjust the dfinsupp ones too?

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 6, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 6, 2023
@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 6, 2023
@YaelDillies
feat: When Finsupp.prod is nonzero (#8844)
ef5e4e8 
Also replace `Finsupp.nonzero_iff_exists` by a more general lemma.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 6, 2023

Canceled.

@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 7, 2023
@YaelDillies
feat: When Finsupp.prod is nonzero (#8844)
2016a40 
Also replace `Finsupp.nonzero_iff_exists` by a more general lemma.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 7, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: When Finsupp.prod is nonzero [Merged by Bors] - feat: When Finsupp.prod is nonzero Dec 7, 2023
@mathlib-bors mathlib-bors bot closed this Dec 7, 2023
@mathlib-bors mathlib-bors bot deleted the finsupp_ne_iff branch December 7, 2023 12:39
awueth pushed a commit that referenced this pull request Dec 19, 2023
@YaelDillies @awueth
feat: When Finsupp.prod is nonzero (#8844)
17e9d45 
Also replace `Finsupp.nonzero_iff_exists` by a more general lemma.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

Assignees
No one assigned
Labels
delegated t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YaelDillies @eric-wieser @leanprover-community-mathlib4-bot