Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add some missing API lemmas about Nat.properDivisors and Nat.primeFactors #8858

Closed
wants to merge 4 commits into from

Conversation

j-loreaux
Copy link
Collaborator


These arose in the context of this thread

Open in Gitpod

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Dec 6, 2023
j-loreaux and others added 3 commits December 11, 2023 23:10
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@urkud
Copy link
Member

urkud commented Dec 24, 2023

I golfed and added 4 more lemmas. LGTM but I guess we need another maintainer now.
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by urkud.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 25, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 25, 2023
….primeFactors` (#8858)

Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 25, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add some missing API lemmas about Nat.properDivisors and Nat.primeFactors [Merged by Bors] - feat: add some missing API lemmas about Nat.properDivisors and Nat.primeFactors Dec 25, 2023
@mathlib-bors mathlib-bors bot closed this Dec 25, 2023
@mathlib-bors mathlib-bors bot deleted the j-loreaux/properDivisors-lemmas branch December 25, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants