-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(FieldTheory/Separable): add AlgEquiv.isSeparable
, AlgEquiv.isSeparable_iff
and IsSeparable.isAlgebraic
#8861
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acmepjz
added
awaiting-review
The author would like community review of the PR
t-algebra
Algebra (groups, rings, fields etc)
labels
Dec 7, 2023
13 tasks
alreadydone
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#8862 will save you a bit of work :) Hopefully it will be merged quickly.
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Dec 7, 2023
# Conflicts: # Mathlib/FieldTheory/Separable.lean
alreadydone
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Dec 7, 2023
Thanks! maintainer merge |
🚀 Pull request has been placed on the maintainer queue by alreadydone. |
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 7, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 7, 2023
…Separable_iff` and `IsSeparable.isAlgebraic` (#8861) - add `AlgEquiv.isSeparable`, `AlgEquiv.isSeparable_iff` which states that `IsSeparable` is invariant under `AlgEquiv` - also add `IsSeparable.isAlgebraic` which states that separable extension is algebraic
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
feat(FieldTheory/Separable): add
[Merged by Bors] - feat(FieldTheory/Separable): add Dec 7, 2023
AlgEquiv.isSeparable
, AlgEquiv.isSeparable_iff
and IsSeparable.isAlgebraic
AlgEquiv.isSeparable
, AlgEquiv.isSeparable_iff
and IsSeparable.isAlgebraic
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
…Separable_iff` and `IsSeparable.isAlgebraic` (#8861) - add `AlgEquiv.isSeparable`, `AlgEquiv.isSeparable_iff` which states that `IsSeparable` is invariant under `AlgEquiv` - also add `IsSeparable.isAlgebraic` which states that separable extension is algebraic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AlgEquiv.isSeparable
,AlgEquiv.isSeparable_iff
which states thatIsSeparable
is invariant underAlgEquiv
IsSeparable.isAlgebraic
which states that separable extension is algebraic