Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(FieldTheory/Separable): add AlgEquiv.isSeparable, AlgEquiv.isSeparable_iff and IsSeparable.isAlgebraic #8861

Closed
wants to merge 3 commits into from

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Dec 7, 2023

  • add AlgEquiv.isSeparable, AlgEquiv.isSeparable_iff which states that IsSeparable is invariant under AlgEquiv
  • also add IsSeparable.isAlgebraic which states that separable extension is algebraic

Open in Gitpod

@acmepjz acmepjz added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 7, 2023
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#8862 will save you a bit of work :) Hopefully it will be merged quickly.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 7, 2023
# Conflicts:
#	Mathlib/FieldTheory/Separable.lean
@alreadydone alreadydone removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 7, 2023
@alreadydone
Copy link
Contributor

Thanks!

maintainer merge

Copy link

github-actions bot commented Dec 7, 2023

🚀 Pull request has been placed on the maintainer queue by alreadydone.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 7, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 7, 2023
…Separable_iff` and `IsSeparable.isAlgebraic` (#8861)

- add `AlgEquiv.isSeparable`, `AlgEquiv.isSeparable_iff` which states that `IsSeparable` is invariant under `AlgEquiv`
- also add `IsSeparable.isAlgebraic` which states that separable extension is algebraic
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 7, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(FieldTheory/Separable): add AlgEquiv.isSeparable, AlgEquiv.isSeparable_iff and IsSeparable.isAlgebraic [Merged by Bors] - feat(FieldTheory/Separable): add AlgEquiv.isSeparable, AlgEquiv.isSeparable_iff and IsSeparable.isAlgebraic Dec 7, 2023
@mathlib-bors mathlib-bors bot closed this Dec 7, 2023
@mathlib-bors mathlib-bors bot deleted the acmepjz_sep_algequiv branch December 7, 2023 22:44
awueth pushed a commit that referenced this pull request Dec 19, 2023
…Separable_iff` and `IsSeparable.isAlgebraic` (#8861)

- add `AlgEquiv.isSeparable`, `AlgEquiv.isSeparable_iff` which states that `IsSeparable` is invariant under `AlgEquiv`
- also add `IsSeparable.isAlgebraic` which states that separable extension is algebraic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants