Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: the affine span is contained in the linear span #8866

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: the affine span is contained in the linear span #8866

wants to merge 5 commits into from

Conversation

sgouezel
Copy link
Contributor

@sgouezel sgouezel commented Dec 7, 2023

Also lint the corresponding file.

Open in Gitpod

@sgouezel sgouezel added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields etc) labels Dec 7, 2023
eric-wieser
eric-wieser approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

It would be nice to also prove the stronger result,

affineSpan k (insert 0 s) = (Submodule.span k s).toAffineSubspace

but that's a bit more work.

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 7, 2023

✌️ sgouezel can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 7, 2023
sgouezel and others added 4 commits December 7, 2023 14:15
@sgouezel @eric-wieser
Update Mathlib/LinearAlgebra/AffineSpace/AffineSubspace.lean
5a5b5e4 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@sgouezel @eric-wieser
Update Mathlib/LinearAlgebra/AffineSpace/AffineSubspace.lean
1e9f2b9 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@sgouezel @eric-wieser
Update Mathlib/LinearAlgebra/AffineSpace/AffineSubspace.lean
6a1a250 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@sgouezel
lint, add set version
723e4fe
@sgouezel
Copy link
Contributor Author

sgouezel commented Dec 7, 2023

bors r+

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 7, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 7, 2023
@sgouezel
feat: the affine span is contained in the linear span (#8866)
b61b03c 
Also lint the corresponding file.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 7, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: the affine span is contained in the linear span [Merged by Bors] - feat: the affine span is contained in the linear span Dec 7, 2023
@mathlib-bors mathlib-bors bot closed this Dec 7, 2023
@mathlib-bors mathlib-bors bot deleted the SG_affineSpan branch December 7, 2023 14:58
awueth pushed a commit that referenced this pull request Dec 19, 2023
@sgouezel @awueth
feat: the affine span is contained in the linear span (#8866)
1a9b56e 
Also lint the corresponding file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgouezel @eric-wieser @leanprover-community-mathlib4-bot