[Merged by Bors] - refactor: Remove leftCoset/rightCoset
#8877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those two definitions are completely obsolete now that we have the pointwise API. This PR removes them but not the corresponding API. A much more tedious subsequent PR will be needed to merge the two API.
YaelDillies
added
awaiting-review
eric-wieser
reviewed
Dec 7, 2023
eric-wieser
reviewed
Dec 7, 2023
eric-wieser
reviewed
Dec 7, 2023
eric-wieser
approved these changes
Dec 7, 2023
|
Let's ask @semorrison since they authored this file... five years ago? 🧓 |
jcommelin
reviewed
Dec 8, 2023
There was a problem hiding this comment.
I am in favour of merging this PR. But I think we should also make serious work of implementing notation for right actions that keeps the action visibly on the right. The version using op will eventually lead to extremely confusing expressions, I'm quite sure.
eric-wieser
reviewed
Dec 8, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
I agree although this is mostly orthogonal to this PR since the |
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2023
Those two definitions are completely obsolete now that we have the pointwise API. This PR removes them but not the corresponding API. A much more tedious subsequent PR will be needed to merge the two API. Note that I need to tweak simp lemmas to keep confluence since I'm merging two pairs of head keys together.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
leftCoset/rightCosetleftCoset/rightCoset
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Those two definitions are completely obsolete now that we have the pointwise API. This PR removes them but not the corresponding API. A much more tedious subsequent PR will be needed to merge the two API. Note that I need to tweak simp lemmas to keep confluence since I'm merging two pairs of head keys together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those two definitions are completely obsolete now that we have the pointwise API. This PR removes them but not the corresponding API. A much more tedious subsequent PR will be needed to merge the two API.
Note that I need to tweak simp lemmas to keep confluence since I'm merging two pairs of head keys together.