New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: Improve Finset
lemma names
#8894
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change a few lemma names that have historically bothered me. * `Finset.card_le_of_subset` → `Finset.card_le_card` * `Multiset.card_le_of_le` → `Multiset.card_le_card` * `Multiset.card_lt_of_lt` → `Multiset.card_lt_card` * `Set.ncard_le_of_subset` → `Set.ncard_le_ncard` * `Finset.image_filter` → `Finset.filter_image` * `CompleteLattice.finset_sup_compact_of_compact` → `CompleteLattice.isCompactElement_finset_sup`
YaelDillies
added
awaiting-review
The author would like community review of the PR
awaiting-CI
labels
Dec 8, 2023
leanprover-community-mathlib4-bot
added
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Dec 14, 2023
leanprover-community-mathlib4-bot
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Dec 19, 2023
jcommelin
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
leanprover-community-mathlib4-bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 27, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 27, 2023
Change a few lemma names that have historically bothered me. * `Finset.card_le_of_subset` → `Finset.card_le_card` * `Multiset.card_le_of_le` → `Multiset.card_le_card` * `Multiset.card_lt_of_lt` → `Multiset.card_lt_card` * `Set.ncard_le_of_subset` → `Set.ncard_le_ncard` * `Finset.image_filter` → `Finset.filter_image` * `CompleteLattice.finset_sup_compact_of_compact` → `CompleteLattice.isCompactElement_finset_sup`
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
chore: Improve
[Merged by Bors] - chore: Improve Dec 27, 2023
Finset
lemma namesFinset
lemma names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change a few lemma names that have historically bothered me.
Finset.card_le_of_subset
→Finset.card_le_card
Multiset.card_le_of_le
→Multiset.card_le_card
Multiset.card_lt_of_lt
→Multiset.card_lt_card
Set.ncard_le_of_subset
→Set.ncard_le_ncard
Finset.image_filter
→Finset.filter_image
CompleteLattice.finset_sup_compact_of_compact
→CompleteLattice.isCompactElement_finset_sup