[Merged by Bors] - feat: Ruzsa covering for sets #8916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a version covering for `Set α` and `Nat.card`.
YaelDillies
added
awaiting-review
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
eric-wieser
reviewed
Dec 9, 2023
Comment on lines
72
to
74
| -- `norm_cast` would find these automatically, but breaks `to_additive` when it does so | ||
| rw [←Finset.coe_mul, ←Finset.coe_mul, ←Finset.coe_div] | ||
| norm_cast |
There was a problem hiding this comment.
@fpvandoorn, any ideas? It looks like norm_cast is generating auxiliary lemmas, but the to_additive tag isn't being transferred to them.
There was a problem hiding this comment.
This is not norm_cast but lift, it seems.
eric-wieser
approved these changes
Dec 9, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
7 tasks
|
I guess we can reference #1074 ? |
|
If we agree that we want to use |
sgouezel
added
awaiting-author
YaelDillies
added
awaiting-review
|
bors r+ |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
Add a version covering for `Set α` and `Nat.card`. From PFR Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a version covering for
Set αandNat.card.From PFR