Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add topological lemmas for ULift #8958

Closed
wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Dec 10, 2023

This also adds a handful of easy instances

Arguably the topological space instance should be defined via coinduced to make these true by Iff.rfl, but that creates a headache with constructors for normed spaces, so is not in this PR.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI labels Dec 10, 2023
@eric-wieser eric-wieser changed the title feat: add topological lemmas for ulift feat: add topological lemmas for ULift Dec 10, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@eric-wieser eric-wieser added the t-topology Topological spaces, uniform spaces, metric spaces, filters label Dec 15, 2023
@urkud
Copy link
Member

urkud commented Dec 17, 2023

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 17, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 17, 2023
This also adds a handful of easy instances

Arguably the topological space instance should be defined via `coinduced` to make these true by `Iff.rfl`, but that creates a headache with constructors for normed spaces, so is not in this PR.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 17, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add topological lemmas for ULift [Merged by Bors] - feat: add topological lemmas for ULift Dec 17, 2023
@mathlib-bors mathlib-bors bot closed this Dec 17, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/ulift-topology branch December 17, 2023 16:08
awueth pushed a commit that referenced this pull request Dec 19, 2023
This also adds a handful of easy instances

Arguably the topological space instance should be defined via `coinduced` to make these true by `Iff.rfl`, but that creates a headache with constructors for normed spaces, so is not in this PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants