Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: add Algebra ℝ A instance given Algebra ℂ A #8991

Closed
wants to merge 4 commits into from

Conversation

j-loreaux
Copy link
Collaborator

@j-loreaux j-loreaux commented Dec 12, 2023

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR t-algebra Algebra (groups, rings, fields etc) labels Dec 12, 2023
@j-loreaux j-loreaux changed the title feat: add Algebra ℝ A instance given Algebra ℂ A. feat: add Algebra ℝ A instance given Algebra ℂ A Dec 12, 2023
@eric-wieser
Copy link
Member

!bench

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 123b74b.
There were significant changes against commit bbc6e56:

  Benchmark      Metric       Change
  ==================================
- open Mathlib   wall-clock     5.6%

@eric-wieser
Copy link
Member

Quoting a private message:

Note: for #8991 this also works:

import Mathlib

variable {A} [Ring A] [Algebra ℝ A]
open Algebra TensorProduct

example : (leftAlgebra : Algebra ℂ (ℂ ⊗[ℝ] A)).complexToReal = leftAlgebra := rfl

I'd like to see this committed too. It can go in test/instance_diamonds.lean once #9037 goes in

@eric-wieser
Copy link
Member

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 15, 2023

✌️ j-loreaux can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 15, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Dec 15, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 17, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 17, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 17, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: add Algebra ℝ A instance given Algebra ℂ A [Merged by Bors] - feat: add Algebra ℝ A instance given Algebra ℂ A Dec 17, 2023
@mathlib-bors mathlib-bors bot closed this Dec 17, 2023
@mathlib-bors mathlib-bors bot deleted the j-loreaux/Algebra.complexToReal branch December 17, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants