Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/UInt, Data/Fin/Basic) declarations #90

Closed
wants to merge 3 commits into from

Commits on Nov 12, 2021

  1. feat(Data/UInt, Data/Fin/Basic) declarations

    Add new Fin instances, extend the UInt declarations to other UInt types using a macro. This incorporates @gebner's suggestions to add boolean methods for checking under/overflow, and adding separate instances of `Fin size`. I still can't figure out the elaboration issue mentioned [here on zulip](https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/simp.20type.20annotations/near/260877092), so I can't use the macro on USize yet.
    ammkrn committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    bd19997 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. refactor(Data/Fin/Basic, Data/UInt)

    Switch over to using the `[Inhabited (Fin n)]` bound, inilne lemmas where possible, and add USize. The Inhabited bound is needed to deal with the combination of `USize.size` not being defined in terms of `Nat.succ`, and `Zero` not giving enough information (by itself) to prove the lemmas needed for classes like AddMonoid. We need to know that `0` from OfNat.ofNat is definitionally equal to something that actually has the requisite properties.
    ammkrn committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    adaf634 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. refactor(Data/Fin/Basic, Data/UInt)

    Inline more items to Ring/CommRing, change some names for consistency.
    ammkrn committed Nov 19, 2021
    Configuration menu
    Copy the full SHA
    0307ddd View commit details
    Browse the repository at this point in the history