Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(Logic/Equiv/Set): fix simpNF #9002

Closed
wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 12, 2023

This was not a false positive becahse h appears in the RHS,
so simp had no way to apply the lemma
if it has some other proof of f x ∈ f '' s.


Open in Gitpod

This was not a false positive becahse `h` appears in the RHS,
so `simp` had no way to apply the lemma
if it has some other proof of `f x ∈ f '' s`.
@urkud urkud added awaiting-review The author would like community review of the PR t-logic Logic (model theory, set theory, etc) labels Dec 12, 2023
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely spotted!

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 12, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 12, 2023
This was not a false positive becahse `h` appears in the RHS,
so `simp` had no way to apply the lemma
if it has some other proof of `f x ∈ f '' s`.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 12, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Logic/Equiv/Set): fix simpNF [Merged by Bors] - fix(Logic/Equiv/Set): fix simpNF Dec 12, 2023
@mathlib-bors mathlib-bors bot closed this Dec 12, 2023
@mathlib-bors mathlib-bors bot deleted the YK-equiv-set-image branch December 12, 2023 16:52
awueth pushed a commit that referenced this pull request Dec 19, 2023
This was not a false positive becahse `h` appears in the RHS,
so `simp` had no way to apply the lemma
if it has some other proof of `f x ∈ f '' s`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants