Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: remove now-unneeded line that worked around linarith preprocessing bug #9009

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: remove now-unneeded line that worked around linarith preprocessing bug #9009

wants to merge 1 commit into from

Conversation

dwrensha
Copy link
Member

After #8310, the workaround in eq_zero_of_d_neg is no longer needed.
I observed (via trace.profiler) no performance difference with this change.

Open in Gitpod

@dwrensha dwrensha added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Dec 12, 2023
@eric-wieser
Copy link
Member

bors merge

Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 12, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 13, 2023
@dwrensha
chore: remove now-unneeded line that worked around linarith preproces…
d14945b 
…sing bug (#9009)

After #8310, the workaround in `eq_zero_of_d_neg` is no longer needed.
I observed (via trace.profiler) no performance difference with this change.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 13, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: remove now-unneeded line that worked around linarith preprocessing bug [Merged by Bors] - chore: remove now-unneeded line that worked around linarith preprocessing bug Dec 13, 2023
@mathlib-bors mathlib-bors bot closed this Dec 13, 2023
@mathlib-bors mathlib-bors bot deleted the pell-nlinarith branch December 13, 2023 00:39
awueth pushed a commit that referenced this pull request Dec 19, 2023
@dwrensha @awueth
chore: remove now-unneeded line that worked around linarith preproces…
9f7a3d2 
…sing bug (#9009)

After #8310, the workaround in `eq_zero_of_d_neg` is no longer needed.
I observed (via trace.profiler) no performance difference with this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dwrensha @eric-wieser