New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port Algebra.Order.Monoid.WithTop #902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joneugster
added
WIP
Work in progress
mathlib-port
This is a port of a theory file from mathlib.
labels
Dec 7, 2022
2 tasks
joneugster
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Dec 8, 2022
jcommelin
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🎉
bors merge
semorrison
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 9, 2022
bors bot
pushed a commit
that referenced
this pull request
Dec 9, 2022
mathlib3: 655994e298904d7e5bbd1e18c95defd7b543eb94 - [x] depends on #910 Not too bad. Mostly renaming instances and a few broken proofs. Things to double-check (all marked with `Porting note`): - `lift` is not implemented yet, I replaced it with `induction`. - In `addSemigroup` I didn't get `repeat` or `repeat'` to work. That could be golfed. - In `WithTop.addHom` the anonymous constructor didn't work, but writing it out, it did. Is that expected? - I'm a bit unsure about coersions. I left in most things and removed (commented out) the lemma `coe_coe_add_hom`. Could be worth gleaming over anything that has `coe` in it's name. Co-authored-by: Jon Eugster <eugster.jon@gmail.com> Co-authored-by: Jon Eugster <Jon.Eugster@hhu.de>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat: port Algebra.Order.Monoid.WithTop
[Merged by Bors] - feat: port Algebra.Order.Monoid.WithTop
Dec 9, 2022
bors bot
pushed a commit
to leanprover-community/mathlib
that referenced
this pull request
Dec 10, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.ulift`: leanprover-community/mathlib4#906 * `algebra.group.with_one.basic`: leanprover-community/mathlib4#922 * `algebra.group_with_zero.units.lemmas`: leanprover-community/mathlib4#920 * `algebra.order.field.defs`: leanprover-community/mathlib4#905 * `algebra.order.group.abs`: leanprover-community/mathlib4#896 * `algebra.order.group.inj_surj`: leanprover-community/mathlib4#916 * `algebra.order.group.type_tags`: leanprover-community/mathlib4#921 * `algebra.order.monoid.with_top`: leanprover-community/mathlib4#902 * `algebra.order.positive.ring`: leanprover-community/mathlib4#911 * `algebra.order.ring.canonical`: leanprover-community/mathlib4#905 * `algebra.order.ring.char_zero`: leanprover-community/mathlib4#905 * `algebra.order.ring.defs`: leanprover-community/mathlib4#905 * `algebra.order.ring.inj_surj`: leanprover-community/mathlib4#917 * `algebra.ring.idempotents`: leanprover-community/mathlib4#918
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mathlib3: 655994e298904d7e5bbd1e18c95defd7b543eb94
WithBot
,WithTop
,WithOne
andWithZero
#910Not too bad. Mostly renaming instances and a few broken proofs.
Things to double-check (all marked with
Porting note
):lift
is not implemented yet, I replaced it withinduction
.addSemigroup
I didn't getrepeat
orrepeat'
to work. That could be golfed.WithTop.addHom
the anonymous constructor didn't work, but writing it out, it did. Is that expected?coe_coe_add_hom
. Could be worth gleaming over anything that hascoe
in it's name.