Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: do not abuse Set.Ioo as a predicate #9027

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - fix: do not abuse Set.Ioo as a predicate #9027

wants to merge 1 commit into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Dec 13, 2023
YaelDillies
YaelDillies approved these changes Dec 14, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. I stand against set abuse.

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

jcommelin
jcommelin approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 14, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 14, 2023
@eric-wieser
fix: do not abuse Set.Ioo as a predicate (#9027)
62d40c8
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 14, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix: do not abuse Set.Ioo as a predicate [Merged by Bors] - fix: do not abuse Set.Ioo as a predicate Dec 14, 2023
@mathlib-bors mathlib-bors bot closed this Dec 14, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/missing-mem branch December 14, 2023 11:42
awueth pushed a commit that referenced this pull request Dec 19, 2023
@eric-wieser @awueth
fix: do not abuse Set.Ioo as a predicate (#9027)
22d9a7e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eric-wieser @jcommelin @YaelDillies @leanprover-community-mathlib4-bot