Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: Fin CharP and lemmas for Fin rollover #9033

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: Fin CharP and lemmas for Fin rollover #9033

wants to merge 6 commits into from

Conversation

pechersky
Copy link
Collaborator

Open in Gitpod

@pechersky @github-actions
Update Mathlib/Data/Fin/Basic.lean
61d0977 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@pechersky pechersky added awaiting-review The author would like community review of the PR awaiting-CI labels Dec 13, 2023
jcommelin
jcommelin approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 27, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 27, 2023
@pechersky
feat: Fin CharP and lemmas for Fin rollover (#9033)
a0ad3e7 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 27, 2023

Build failed (retrying...):

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 27, 2023

Canceled.

@pechersky
Copy link
Collaborator Author

bors merge

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 29, 2023

🔒 Permission denied

Existing reviewers: click here to make pechersky a reviewer

@pechersky pechersky added awaiting-review The author would like community review of the PR and removed ready-to-merge This PR has been sent to bors. labels Dec 29, 2023
@alreadydone alreadydone added auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. and removed auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. labels Dec 29, 2023
@alreadydone
Copy link
Contributor

Let's get it merge by retriggering CI with added label.

@leanprover-community-mathlib4-bot
Copy link
Collaborator

As this PR is labelled auto-merge-after-CI, we are now sending it to bors:

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 31, 2023
@pechersky @alreadydone
feat: Fin CharP and lemmas for Fin rollover (#9033)
7d31d03 
Co-authored-by: Yakov Pechersky <pechersky@users.noreply.github.com>
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 31, 2023

Pull request successfully merged into master.

Build succeeded!

And happy new year! 🎉

@mathlib-bors mathlib-bors bot changed the title feat: Fin CharP and lemmas for Fin rollover [Merged by Bors] - feat: Fin CharP and lemmas for Fin rollover Dec 31, 2023
@mathlib-bors mathlib-bors bot closed this Dec 31, 2023
@mathlib-bors mathlib-bors bot deleted the pechersky/fin-order-lemmas branch December 31, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone left review comments

@github-actions github-actions[bot] github-actions left review comments

@jcommelin jcommelin Awaiting requested review from jcommelin

Assignees
No one assigned
Labels
auto-merge-after-CI Please do not add manually. Requests for a bot to merge automatically once CI is done. awaiting-review The author would like community review of the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pechersky @alreadydone @leanprover-community-mathlib4-bot @jcommelin