[Merged by Bors] - perf (AlgebraicGeometry.Properties): Speed up one declaration #9035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrobball
added
awaiting-review
|
!bench |
|
Here are the benchmark results for commit bc6e97d. Benchmark Metric Change
=============================================================
+ ~Mathlib.AlgebraicGeometry.Properties instructions -34.7% |
YaelDillies
approved these changes
Dec 14, 2023
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
alreadydone
reviewed
Dec 14, 2023
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
jcommelin
approved these changes
Dec 14, 2023
|
✌️ mattrobball can now approve this pull request. To approve and merge a pull request, simply reply with |
leanprover-community-mathlib4-bot
added
delegated
and removed
awaiting-review
|
!bench |
|
Here are the benchmark results for commit a5cf391. Benchmark Metric Change
=============================================================
+ ~Mathlib.AlgebraicGeometry.Properties instructions -35.2% |
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
This speeds up on declaration by breaking up a defeq check into a single task. Co-authored-by: Johan Commelin <johan@commelin.net>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
This speeds up on declaration by breaking up a defeq check into a single task. Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up on declaration by breaking up a defeq check into a single task.