Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(LinearAlgebra/Matrix): powers preserve IsSymm and IsHermitian #9036

Closed
wants to merge 3 commits into from

Conversation

eric-wieser
Copy link
Member


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Dec 13, 2023
@loefflerd
Copy link
Collaborator

Wouldn't it be better to instead prove the more general result that if A and B are Hermitian and commute with each other, then A * B is Hermitian, and deduce the result for powers as a special case?

@eric-wieser
Copy link
Member Author

I strongly suspect "it follows" results in a longer proof than the one I already have that just uses the existing facts about power and conjugate transpose commuting.

However, the lemma you suggest did cross my mind, and would indeed be a good result to have; I'll add the hermitian version of IsSelfAdjoint.commute_iff to this PR in a few hours.

@loefflerd
Copy link
Collaborator

I strongly suspect "it follows" results in a longer proof than the one I already have

I know. The suggestion wasn't intended to be taken seriously. It was intended as a demonstration of how annoying it is when people hijack a simple PR with demands for more and more tangentially-related extra functionality (as you have been doing at #8809).

@j-loreaux
Copy link
Collaborator

I have to say I don't love this thing of duplicating all the API for star structures. That seems silly. @eric-wieser thoughts?

@eric-wieser
Copy link
Member Author

I replaced the proof for IsHermitian.pow with a call to the IsSelfAdjoint API. The zpow result is novel because the zpow operator on matrices is not captured by any existing typeclass.

@j-loreaux
Copy link
Collaborator

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 15, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 15, 2023
@eric-wieser
Copy link
Member Author

As discussed privately, a future refactor could consider renaming IsHermitian.zpow to IsSelfAdjoint.matrix_zpow, though such a change would amount to refactoring this entire file and so isn't really in scope for this PR.

In the meantime, we should continue to re-use IsSelfAdjoint proofs wherever possible in this file rather than reproving things.

@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 15, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 16, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(LinearAlgebra/Matrix): powers preserve IsSymm and IsHermitian [Merged by Bors] - feat(LinearAlgebra/Matrix): powers preserve IsSymm and IsHermitian Dec 16, 2023
@mathlib-bors mathlib-bors bot closed this Dec 16, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/matrix-pow branch December 16, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants