New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(LinearAlgebra/Matrix): powers preserve IsSymm
and IsHermitian
#9036
Conversation
eric-wieser
commented
Dec 13, 2023
Wouldn't it be better to instead prove the more general result that if |
I strongly suspect "it follows" results in a longer proof than the one I already have that just uses the existing facts about power and conjugate transpose commuting. However, the lemma you suggest did cross my mind, and would indeed be a good result to have; I'll add the hermitian version of |
I know. The suggestion wasn't intended to be taken seriously. It was intended as a demonstration of how annoying it is when people hijack a simple PR with demands for more and more tangentially-related extra functionality (as you have been doing at #8809). |
I have to say I don't love this thing of duplicating all the API for star structures. That seems silly. @eric-wieser thoughts? |
I replaced the proof for |
bors d+ |
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
As discussed privately, a future refactor could consider renaming In the meantime, we should continue to re-use |
bors merge |
Pull request successfully merged into master. Build succeeded: |
IsSymm
and IsHermitian
IsSymm
and IsHermitian