Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Filter/{NAry,Pointwise}): add missing NeBot instances #9055

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(Filter/{NAry,Pointwise}): add missing NeBot instances #9055

wants to merge 2 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 14, 2023

  • Add missing Filter.NeBot instances for Filter.map₂ and pointwise operations, rename Filter.prod_neBot' to Filter.prod.instNeBot.
  • Make Filter.prod_eq_bot a simp lemma.
  • Protect some lemmas.
  • Golf some proofs.
  • Make Filter.map₂_left and Filter.map₂_right take NeBot argument as an instance.

Open in Gitpod

@urkud
feat(Filter/{NAry,Pointwise}): add missing NeBot instances
8ed7660 
- Add missing `Filter.NeBot` instances for `Filter.map₂` and pointwise
  operations, rename `Filter.prod_neBot'` to `Filter.prod.instNeBot`.
- Make `Filter.prod_eq_bot` a `simp` lemma.
- Protect some lemmas.
- Golf some proofs.
- Make `Filter.map₂_left` and `Filter.map₂_right`
  take `NeBot` argument as an instance.
@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-order Order hierarchy labels Dec 14, 2023
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 20, 2023
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 20, 2023
@sgouezel
Copy link
Contributor

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 20, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 20, 2023
@urkud
feat(Filter/{NAry,Pointwise}): add missing NeBot instances (#9055)
58d258c 
- Add missing `Filter.NeBot` instances for `Filter.map₂` and pointwise operations, rename `Filter.prod_neBot'` to `Filter.prod.instNeBot`.
- Make `Filter.prod_eq_bot` a `simp` lemma.
- Protect some lemmas.
- Golf some proofs.
- Make `Filter.map₂_left` and `Filter.map₂_right` take `NeBot` argument as an instance.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 20, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Filter/{NAry,Pointwise}): add missing NeBot instances [Merged by Bors] - feat(Filter/{NAry,Pointwise}): add missing NeBot instances Dec 20, 2023
@mathlib-bors mathlib-bors bot closed this Dec 20, 2023
@mathlib-bors mathlib-bors bot deleted the YK-filter-map2-neBot branch December 20, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-order Order hierarchy t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @sgouezel @eric-wieser