[Merged by Bors] - chore(Data/Finset): golf #9058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Golf the proof of `Finset.subset_image₂` by reusing `Finset.subset_image_iff`. Should it be `subset_image₂` or `subset_image2`? Or should we rename `Set.image2` to `Set.image₂`?
urkud
added
awaiting-review
leanprover-community-mathlib4-bot
added
ready-to-merge
cc @YaelDillies |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
Golf the proof of `Finset.subset_image₂` by reusing `Finset.subset_image_iff`.
|
I'm a bit split on the matter. Neither name really conveys the meaning properly. Maybe we should rename both to something like |
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Golf the proof of `Finset.subset_image₂` by reusing `Finset.subset_image_iff`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golf the proof of
Finset.subset_image₂by reusingFinset.subset_image_iff.Should it be
subset_image₂orsubset_image2?Or should we rename
Set.image2toSet.image₂?