Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: golf and generalize discr_eq_discr_of_algEquiv #9068

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: golf and generalize discr_eq_discr_of_algEquiv #9068

wants to merge 1 commit into from

Conversation

alreadydone
Copy link
Contributor

Open in Gitpod

@alreadydone alreadydone added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Dec 15, 2023
@alreadydone alreadydone mentioned this pull request Dec 15, 2023
Closed
@alreadydone alreadydone added the t-algebra Algebra (groups, rings, fields etc) label Dec 15, 2023
xroblot
xroblot approved these changes Dec 15, 2023
View reviewed changes
Copy link
Collaborator

@xroblot xroblot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@riccardobrasca
Copy link
Member

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 15, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 15, 2023
@alreadydone
chore: golf and generalize discr_eq_discr_of_algEquiv (#9068)
5ab7021 
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 15, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: golf and generalize discr_eq_discr_of_algEquiv [Merged by Bors] - chore: golf and generalize discr_eq_discr_of_algEquiv Dec 15, 2023
@mathlib-bors mathlib-bors bot closed this Dec 15, 2023
@mathlib-bors mathlib-bors bot deleted the golf_discr branch December 15, 2023 10:48
awueth pushed a commit that referenced this pull request Dec 19, 2023
@alreadydone @awueth
chore: golf and generalize discr_eq_discr_of_algEquiv (#9068)
7753859 
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xroblot xroblot xroblot approved these changes

Assignees
No one assigned
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alreadydone @riccardobrasca @xroblot