Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Algebra/Star/Order): more lemmas #9096

Closed
wants to merge 8 commits into from

Conversation

eric-wieser
Copy link
Member


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Dec 16, 2023
Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the induction proofs. Looks good.

Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
Mathlib/Algebra/Star/Order.lean Outdated Show resolved Hide resolved
@j-loreaux
Copy link
Collaborator

bors d+

@mathlib-bors
Copy link

mathlib-bors bot commented Dec 18, 2023

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 18, 2023
@j-loreaux j-loreaux changed the title feat(algebra/star/order): more lemmas feat(Algebra/Star/Order): more lemmas Dec 18, 2023
eric-wieser and others added 2 commits December 18, 2023 12:55
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
@eric-wieser
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Dec 18, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 18, 2023
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 18, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Algebra/Star/Order): more lemmas [Merged by Bors] - feat(Algebra/Star/Order): more lemmas Dec 18, 2023
@mathlib-bors mathlib-bors bot closed this Dec 18, 2023
@mathlib-bors mathlib-bors bot deleted the eric-wieser/more-star-order branch December 18, 2023 14:27
awueth pushed a commit that referenced this pull request Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants