Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: More rpow lemmas #9108

Closed
wants to merge 5 commits into from
Closed

Conversation

YaelDillies
Copy link
Collaborator

A bunch of easy lemmas about Real.pow and the golf of existing lemmas with them.

Also rename log_le_log to log_le_log_iff and log_le_log' to log_le_log. Those misnames caused several proofs to bother with side conditions they didn't need.

From LeanAPAP


Open in Gitpod

A bunch of easy lemmas about `Real.pow` and the golf of existing lemmas with them.

Also rename `log_le_log` to `log_le_log_iff` and `log_le_log'` to `log_le_log`. Those misnames caused several proofs to bother with side conditions they didn't need.

From LeanAPAP
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR t-analysis Analysis (normed *, calculus) labels Dec 16, 2023
#align real.rpow_int_cast Real.rpow_int_cast

@[simp, norm_cast]
theorem rpow_nat_cast (x : ℝ) (n : ℕ) : x ^ (n : ℝ) = x ^ n := by simpa using rpow_int_cast x n
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats with these being nat_cast vs natCast elsewhere?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've hardly decided on a convention. I'm personally in favor of natCast (and the poll a few months back agrees with me) but most lemmas have been ported as nat_cast. This lemma is just moving, so I'm not changing its name. However I'm naming the new ones using natCast.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 18, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 19, 2023
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

Mathlib/Analysis/SpecialFunctions/Log/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/SpecialFunctions/Stirling.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/SpecialFunctions/Stirling.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 19, 2023

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 19, 2023
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@YaelDillies
Copy link
Collaborator Author

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 19, 2023
A bunch of easy lemmas about `Real.pow` and the golf of existing lemmas with them.

Also rename `log_le_log` to `log_le_log_iff` and `log_le_log'` to `log_le_log`. Those misnames caused several proofs to bother with side conditions they didn't need.

From LeanAPAP
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 19, 2023

Build failed (retrying...):

  • Build

mathlib-bors bot pushed a commit that referenced this pull request Dec 19, 2023
A bunch of easy lemmas about `Real.pow` and the golf of existing lemmas with them.

Also rename `log_le_log` to `log_le_log_iff` and `log_le_log'` to `log_le_log`. Those misnames caused several proofs to bother with side conditions they didn't need.

From LeanAPAP
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 19, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: More rpow lemmas [Merged by Bors] - feat: More rpow lemmas Dec 19, 2023
@mathlib-bors mathlib-bors bot closed this Dec 19, 2023
@mathlib-bors mathlib-bors bot deleted the log_le_log branch December 19, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-analysis Analysis (normed *, calculus)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants