[Merged by Bors] - chore(Ideal/Operations): remove extraneous nonempty conditions #9115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alreadydone
added
awaiting-review
alreadydone
changed the title
alreadydone
commented
Dec 16, 2023
alreadydone
commented
Dec 16, 2023
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
alreadydone
added
awaiting-CI
awaiting-author
alreadydone
added
awaiting-review
alreadydone
removed
easy
erdOne
reviewed
Dec 17, 2023
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by erdOne. |
alreadydone
commented
Dec 17, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 17, 2023
Also generalizes `Ideal.subset_union` to `Subgroup`. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Also generalizes `Ideal.subset_union` to `Subgroup`. Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also generalizes
Ideal.subset_uniontoSubgroup.