New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: adaptations for leanprover/lean4#2973 #9161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
semorrison
added
awaiting-review
The author would like community review of the PR
awaiting-CI
labels
Dec 20, 2023
semorrison
force-pushed
the
adaptation_2973
branch
from
December 20, 2023 09:59
0e453e8
to
9415d05
Compare
bors d+ |
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
The author would like community review of the PR
labels
Dec 21, 2023
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
This is a PR to Mathlib's `bump/v4.5.0` branch, containing adaptations required for leanprover/lean4#2973, which landed in `leanprover/lean4:nightly-2023-12-19` and will become part of `v4.5.0-rc1` soon. Co-authored-by: Kyle Miller <kmill31415@gmail.com> Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Pull request successfully merged into bump/v4.5.0. Build succeeded: |
mathlib-bors
bot
changed the title
chore: adaptations for leanprover/lean4#2973
[Merged by Bors] - chore: adaptations for leanprover/lean4#2973
Dec 21, 2023
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
…h. (#9188) This PR: * bumps to lean-toolchain to `v4.5.0-rc1` * bumps the Std and Aesop dependencies to their versions using `v4.5.0-rc1` * merge the already reviewed changes from the `bump/v4.5.0` branch * adaptations for leanprover/lean4#2923 in #9011 * adaptations for leanprover/lean4#2973 in #9161 * adaptations for leanprover/lean4#2964 in #9176 Co-authored-by: Scott Morrison <scott.morrison@gmail.com> Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to Mathlib's
bump/v4.5.0
branch, containing adaptations required for leanprover/lean4#2973, which landed inleanprover/lean4:nightly-2023-12-19
and will become part ofv4.5.0-rc1
soon.This PR was made by cherry-picking the relevant commits from @kmill's
lean-pr-testing-2973
branch. (A bit of trial and error to find them all, actually.)Done:
This PR is not quite ready to merge: it is waiting on leanprover-community/batteries#470, after which we need to set the Std dependency back tobump/v4.5.0
.Done:
Moreover, I think it won't build until #9162 is merged intobump/v4.5.0
and this PR...