New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore(Algebra.Module.LocalizedModule): use IsLocalization
instead of Localization
#9167
Conversation
I wonder if this should be done with |
In #9210 Mathlib/RingTheory/Localization/Module.lean imports Mathlib/Algebra/Module/LocalizedModule.lean instead, which IMO is the right direction. What in that file does this PR need? |
Oh I see. We should probably find a better home for |
Yes, as you can see most of the heavy lifting is done in #9210. This PR is just about replacing |
This is strictly more general than the current situation, right? |
Yes, the result about |
Thanks, let's merge this and maybe improve things later. bors merge |
…f `Localization` (#9167) The construction of `LocalizedModule` is done using `IsLocalization` rather than `Localization`. The corresponding instances for `Localization` are deduced automatically by Lean. One drawback is that many instances are now marked `noncomputable`.
Pull request successfully merged into master. Build succeeded! And happy new year! 🎉 |
IsLocalization
instead of Localization
IsLocalization
instead of Localization
The construction of
LocalizedModule
is done usingIsLocalization
rather thanLocalization
. The corresponding instances forLocalization
are deduced automatically by Lean. One drawback is that many instances are now markednoncomputable
.