Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - fix(Data/Option/Defs): Remove Option.rel and Option.maybe, superceded by std4 #9178

Closed
wants to merge 2 commits into from

Conversation

linesthatinterlace
Copy link
Collaborator

Remove Option.rel and Option.maybe, which have identical definitions to Option.Rel and Option.sequence, and aren't used anywhere.


Open in Gitpod

@linesthatinterlace linesthatinterlace added awaiting-review easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Dec 21, 2023
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Nice catch!

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 21, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 21, 2023
…eded by std4 (#9178)

Remove `Option.rel` and `Option.maybe`, which have identical definitions to `Option.Rel` and `Option.sequence`, and aren't used anywhere.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 21, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title fix(Data/Option/Defs): Remove Option.rel and Option.maybe, superceded by std4 [Merged by Bors] - fix(Data/Option/Defs): Remove Option.rel and Option.maybe, superceded by std4 Dec 21, 2023
@mathlib-bors mathlib-bors bot closed this Dec 21, 2023
@mathlib-bors mathlib-bors bot deleted the remove_option_rel branch December 21, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants