[Merged by Bors] - chore(Set/NAry): drop Set.image3
#9221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urkud
added
awaiting-review
YaelDillies
approved these changes
Dec 22, 2023
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
@YaelDillies, please edit the PR description to explain why we should drop this and what the intended replacement is bors d=@YaelDillies |
|
✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 22, 2023
`Set.image3` was only used to prove associativity of `Set.image2`. It had basically no API and had exactly one (easily replaced) use outside `Data.Set.NAry`). There is no specific function as a replacement, but it can be obtained by combining `Set.image2` twice.
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
Set.image3Set.image3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set.image3was only used to prove associativity ofSet.image2. It had basically no API and had exactly one (easily replaced) use outsideData.Set.NAry). There is no specific function as a replacement, but it can be obtained by combiningSet.image2twice.As requested by @YaelDillies