Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - refactor(Order/Extension): use OrderHom #9232

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - refactor(Order/Extension): use OrderHom #9232

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 23, 2023

Redefine toLinearExtension as an OrderHom.

Open in Gitpod

@urkud
refactor(Order/Extension): use OrderHom
a5c8c09 
Redefine `toLinearExtension` as an `OrderHom`.
@urkud urkud added awaiting-review The author would like community review of the PR t-order Order hierarchy labels Dec 23, 2023
YaelDillies
YaelDillies approved these changes Dec 23, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

jcommelin
jcommelin approved these changes Dec 23, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 23, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 23, 2023
@urkud
refactor(Order/Extension): use OrderHom (#9232)
bb307ab 
Redefine `toLinearExtension` as an `OrderHom`.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 23, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor(Order/Extension): use OrderHom [Merged by Bors] - refactor(Order/Extension): use OrderHom Dec 23, 2023
@mathlib-bors mathlib-bors bot closed this Dec 23, 2023
@mathlib-bors mathlib-bors bot deleted the YK-to-ext branch December 23, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-order Order hierarchy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @jcommelin @YaelDillies @leanprover-community-mathlib4-bot