Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Topology/FilterBasis): rename GroupFilterBasis.prod_subset_self #9233

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore(Topology/FilterBasis): rename GroupFilterBasis.prod_subset_self #9233

wants to merge 1 commit into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 23, 2023

... to subset_mul_self

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters t-algebra Algebra (groups, rings, fields etc) labels Dec 23, 2023
jcommelin
jcommelin approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 27, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 27, 2023
@urkud
chore(Topology/FilterBasis): rename `GroupFilterBasis.prod_subset_sel…
2980d2b 
…f` (#9233)

... to `subset_mul_self`
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 27, 2023

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Dec 27, 2023
@urkud
chore(Topology/FilterBasis): rename `GroupFilterBasis.prod_subset_sel…
bbf5f35 
…f` (#9233)

... to `subset_mul_self`
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 27, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore(Topology/FilterBasis): rename GroupFilterBasis.prod_subset_self [Merged by Bors] - chore(Topology/FilterBasis): rename GroupFilterBasis.prod_subset_self Dec 27, 2023
@mathlib-bors mathlib-bors bot closed this Dec 27, 2023
@mathlib-bors mathlib-bors bot deleted the YK-filter-basis-rename branch December 27, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @jcommelin @leanprover-community-mathlib4-bot