Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - doc: Example use case of Finset.filter #9239

Closed
wants to merge 4 commits into from

Conversation

MichaelStollBayreuth
Copy link
Collaborator

Mention the spelling s.filter (· ∈ t) for the intersection of s : Finset α and t : Set α as a Finset α in the docstring of Finset.filter.

See here on Zulip.


Open in Gitpod

@MichaelStollBayreuth MichaelStollBayreuth added documentation Improvements or additions to documentation awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. awaiting-CI labels Dec 23, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@YaelDillies YaelDillies changed the title doc(Data.Finset.Basic): add example use case to def. of Finset.filter doc: Example use case of Finset.filter Dec 23, 2023
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully that will help future readers.

maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 23, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 23, 2023
Mention the spelling `s.filter (· ∈ t)` for the intersection of `s : Finset α` and `t : Set α` as a `Finset α` in the docstring of `Finset.filter`.

See [here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Intersection.20of.20a.20Finset.20and.20a.20Set.20as.20a.20Finset.3F/near/409632763) on Zulip.



Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 23, 2023

Build failed (retrying...):

mathlib-bors bot pushed a commit that referenced this pull request Dec 23, 2023
Mention the spelling `s.filter (· ∈ t)` for the intersection of `s : Finset α` and `t : Set α` as a `Finset α` in the docstring of `Finset.filter`.

See [here](https://leanprover.zulipchat.com/#narrow/stream/217875-Is-there-code-for-X.3F/topic/Intersection.20of.20a.20Finset.20and.20a.20Set.20as.20a.20Finset.3F/near/409632763) on Zulip.



Co-authored-by: Michael Stoll <99838730+MichaelStollBayreuth@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 23, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title doc: Example use case of Finset.filter [Merged by Bors] - doc: Example use case of Finset.filter Dec 23, 2023
@mathlib-bors mathlib-bors bot closed this Dec 23, 2023
@mathlib-bors mathlib-bors bot deleted the MS_finset_filter_doc branch December 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants