Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore: Generalise monotonicity of lemmas in modules #9241

Closed
wants to merge 2 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Sort the lemmas in Algebra.Order.Module into Algebra.Order.Module.Defs and Algebra.Order.Module.Pointwise. Generalise them.

A later PR will rename the lemmas to better match the naming convention.


Open in Gitpod

Sort the lemmas in `Algebra.Order.Module` into `Algebra.Order.Module.Defs` and `Algebra.Order.Module.Pointwise`. Generalise them.

A later PR will rename the lemmas to better match the naming convention.
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy labels Dec 23, 2023
exact smul_lt_smul_of_pos_left hb (neg_pos_of_neg ha)
#align smul_lt_smul_of_neg smul_lt_smul_of_neg

lemma strict_anti_smul_left (ha : a < 0) : StrictAnti (SMul.smul a : β → β) :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma strict_anti_smul_left (ha : a < 0) : StrictAnti (SMul.smul a : β → β) :=
lemma strictAnti_smul_left (ha : a < 0) : StrictAnti (SMul.smul a : β → β) :=

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on my TODO list, but I'm not renaming anything in this PR!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 26, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 26, 2023
Sort the lemmas in `Algebra.Order.Module` into `Algebra.Order.Module.Defs` and `Algebra.Order.Module.Pointwise`. Generalise them.

A later PR will rename the lemmas to better match the naming convention.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 26, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: Generalise monotonicity of lemmas in modules [Merged by Bors] - chore: Generalise monotonicity of lemmas in modules Dec 26, 2023
@mathlib-bors mathlib-bors bot closed this Dec 26, 2023
@mathlib-bors mathlib-bors bot deleted the scavenge_ordered_module branch December 26, 2023 23:40
YaelDillies added a commit that referenced this pull request Dec 27, 2023
Fix the names of the lemmas moved in #9241 to match the naming convention.
mathlib-bors bot pushed a commit that referenced this pull request Dec 27, 2023
Fix the names of the lemmas moved in #9241 to match the naming convention.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc) t-order Order hierarchy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants