Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(*/Pointwise): generalize some lemmas to SMulZeroClass #9243

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat(*/Pointwise): generalize some lemmas to SMulZeroClass #9243

wants to merge 7 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Dec 23, 2023 •
edited

@YaelDillies Are there any other files I should adjust simultaneously?

Open in Gitpod

@urkud urkud added awaiting-review The author would like community review of the PR t-logic Logic (model theory, set theory, etc) labels Dec 23, 2023
@YaelDillies
Copy link
Collaborator

This will conflict with #9199. Do you mind adapting your PR to match?

You should adjust Order.Filter.Pointwise too.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Dec 28, 2023
@urkud @YaelDillies
Update Mathlib/Data/Finset/Pointwise.lean
cb6fdb0 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@urkud @YaelDillies
Update Mathlib/Data/Set/Pointwise/SMul.lean
86ff46c 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@urkud @YaelDillies
Update Mathlib/Data/Finset/Pointwise.lean
f274c25 
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
YaelDillies approved these changes Dec 29, 2023
View reviewed changes
Copy link
Collaborator

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

maintainer merge

@github-actions GitHub Actions
Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@dupuisf
Copy link
Contributor

dupuisf commented Dec 30, 2023

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 30, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 30, 2023
@urkud
feat(*/Pointwise): generalize some lemmas to SMulZeroClass (#9243)
d54b614
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 30, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(*/Pointwise): generalize some lemmas to SMulZeroClass [Merged by Bors] - feat(*/Pointwise): generalize some lemmas to SMulZeroClass Dec 30, 2023
@mathlib-bors mathlib-bors bot closed this Dec 30, 2023
@mathlib-bors mathlib-bors bot deleted the YK-smul-zero branch December 30, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaelDillies YaelDillies YaelDillies approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @YaelDillies @dupuisf @leanprover-community-mathlib4-bot