Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: audit remaining uses of "local homeomorphism" in comments #9245

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - chore: audit remaining uses of "local homeomorphism" in comments #9245

wants to merge 4 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Dec 23, 2023 •
edited

Almost all of them should speak about partial homeomorphisms instead.
In two cases, I decided removing the "local" was clearer than adding "partial".

Follow-up to #8982; complements #9238.

Best reviewed commit by commit.

@grunweg grunweg added awaiting-review The author would like community review of the PR t-topology Topological spaces, uniform spaces, metric spaces, filters labels Dec 23, 2023
@grunweg grunweg force-pushed the MR-partialhom-rename-comments branch from d475ed2 to e81bfb8 Compare December 23, 2023 17:40
jcommelin
jcommelin approved these changes Dec 26, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 26, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 26, 2023
@grunweg
chore: audit remaining uses of "local homeomorphism" in comments (#9245)
a76fbc3 
Almost all of them should speak about partial homeomorphisms instead.
In two cases, I decided removing the "local" was clearer than adding "partial".

Follow-up to #8982; complements #9238.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 26, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: audit remaining uses of "local homeomorphism" in comments [Merged by Bors] - chore: audit remaining uses of "local homeomorphism" in comments Dec 26, 2023
@mathlib-bors mathlib-bors bot closed this Dec 26, 2023
@mathlib-bors mathlib-bors bot deleted the MR-partialhom-rename-comments branch December 26, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grunweg @jcommelin @leanprover-community-mathlib4-bot