Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: bijective local homeomorphisms are homeomorphisms #9247

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: bijective local homeomorphisms are homeomorphisms #9247

wants to merge 5 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Dec 23, 2023

Basis for generalising the result for local diffeomorphism to local structomorphisms.

@grunweg
WIP: bijective local homeo is a homeo
f7d15cb 
not cleaned up; perhaps want a different approach?
@grunweg grunweg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters labels Dec 23, 2023
@grunweg grunweg changed the title feat: bijective local homeomorphism is a homeomorphism feat: bijective local homeomorphisms are homeomorphisms Dec 23, 2023
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 25, 2023
@grunweg
Copy link
Collaborator Author

grunweg commented Dec 25, 2023

Thanks for the quick look, @ADedecker!
I addressed the review comment. Sorry for the force-push; only the last comment is new.
awaiting-review

@github-actions github-actions bot added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 25, 2023
@grunweg grunweg mentioned this pull request Dec 25, 2023
Closed
ADedecker
ADedecker approved these changes Dec 25, 2023
View reviewed changes
Copy link
Member

@ADedecker ADedecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

Mathlib/Topology/IsLocalHomeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Maps.lean Outdated Show resolved Hide resolved
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 25, 2023

✌️ grunweg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added delegated and removed awaiting-review The author would like community review of the PR labels Dec 25, 2023
grunweg and others added 2 commits December 25, 2023 19:18
@grunweg @ADedecker
Review comments.
014fae6 
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@grunweg @ADedecker
Other comment.
34df2f5 
Co-authored-by: Anatole Dedecker <anatolededecker@gmail.com>
@grunweg
Copy link
Collaborator Author

grunweg commented Dec 25, 2023

Thank you for the fast review.
bors r+

mathlib-bors bot pushed a commit that referenced this pull request Dec 25, 2023
@grunweg
feat: bijective local homeomorphisms are homeomorphisms (#9247)
93e820f 
Basis for generalising the result for local diffeomorphism to local structomorphisms.

Co-authored-by: grunweg <grunweg@posteo.de>
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 25, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: bijective local homeomorphisms are homeomorphisms [Merged by Bors] - feat: bijective local homeomorphisms are homeomorphisms Dec 25, 2023
@mathlib-bors mathlib-bors bot closed this Dec 25, 2023
@mathlib-bors mathlib-bors bot deleted the MR-localhomeo branch December 25, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADedecker ADedecker ADedecker approved these changes

Assignees
No one assigned
Labels
delegated easy < 20s of review time. See the lifecycle page for guidelines. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grunweg @ADedecker @leanprover-community-mathlib4-bot