Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Add Uncountable #9254

Closed
wants to merge 16 commits into from
Closed

Conversation

JADekker
Copy link
Collaborator

@JADekker JADekker commented Dec 24, 2023

Adds the Uncountable class to Countable/Defs and some basic API.


More to follow, but I'd like to get feedback on the way of writing first!

Open in Gitpod

Add Filter.cocountable: the filter generated by sets with countable
complements.

Add some basic API.
@JADekker JADekker added awaiting-review The author would like community review of the PR awaiting-CI t-logic Logic (model theory, set theory, etc) new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! labels Dec 24, 2023
@alexjbest alexjbest changed the title Feat : Add Uncountable feat: Add Uncountable Dec 24, 2023
Mathlib/Data/Countable/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Data/Countable/Defs.lean Outdated Show resolved Hide resolved
@alexjbest
Copy link
Member

Do you have a link to the other things you want to add?

@JADekker
Copy link
Collaborator Author

JADekker commented Dec 24, 2023

Thanks, I’ll take a look at any remaining adjustments soon, but I see that @urkud is only working busily on this, thank you!

@alexjbest, let me start by providing some short background:

the reason why I’m implementing this is that I’m working on Lindelöf spaces in #9107. I’d like to introduce the cocountable filter (analogous to the way the cofinite filter is used for Compact spaces) and it came up in discussions on Zulip that, rather than writing \neg Countable at some points in the definitions, it might be nicer to have Uncountable.

As such I’ll mirror the contents from Countable/Basic for Uncountable, but after that I’ll probably only add whatever comes up that I need to define cocountable filters (but I’ll try to prove and add sufficiently general versions of whatever I’m using).

@urkud
Copy link
Member

urkud commented Dec 24, 2023

I'm done working on this branch. I think that this PR needs the instance for functions I posted on Zulip and the docstring fix suggested by Alex; otherwise it's ready. The instance should probably go to Data/Fintype/Card, because you'll need Infinite.natEmbedding.

@JADekker
Copy link
Collaborator Author

JADekker commented Dec 24, 2023

Great, will try to do this in a few days; if anyone has time and wants to add them, feel free of course! I’ll send a heads-up when I continue working on this.

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 25, 2023
@JADekker
Copy link
Collaborator Author

JADekker commented Dec 26, 2023

@urkud Do you mean the instance
[Uncountable α] : NeBot (cocountable α)
that you suggested in Zulip, or do you mean another one? This one requires the definition of the cocountable filter which I haven't PR'ed yet, and requires filters, so I think Data/Fintype/Card may be too far upstream (as I'll need to get NeBot, which comes from Filter/Basic). Perhaps I should include it in the PR for Filter/Cocountable when this PR gets merged? I suggest that I make a new PR that defines the cocountable filter once this PR and #9200 have merged; I can add this instance to that!

@JADekker JADekker added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 26, 2023
@JADekker JADekker requested a review from urkud December 26, 2023 08:53
Mathlib/Data/Countable/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Countable/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Data/Countable/Basic.lean Show resolved Hide resolved
Mathlib/Data/Countable/Defs.lean Outdated Show resolved Hide resolved
Mathlib/Data/Countable/Defs.lean Outdated Show resolved Hide resolved
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@YaelDillies YaelDillies added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Dec 31, 2023
JADekker and others added 2 commits December 31, 2023 14:22
@JADekker JADekker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Dec 31, 2023
@urkud
Copy link
Member

urkud commented Jan 5, 2024

Thanks! 🎉
bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jan 5, 2024
mathlib-bors bot pushed a commit that referenced this pull request Jan 5, 2024
Adds the Uncountable class to `Countable/Defs` and some basic API.



Co-authored-by: Yury G. Kudryashov <urkud@urkud.name>
@mathlib-bors
Copy link

mathlib-bors bot commented Jan 5, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: Add Uncountable [Merged by Bors] - feat: Add Uncountable Jan 5, 2024
@mathlib-bors mathlib-bors bot closed this Jan 5, 2024
@mathlib-bors mathlib-bors bot deleted the JADekker_uncountable branch January 5, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-contributor This PR was made by a contributor with fewer than 5 merged PRs. Welcome to the community! ready-to-merge This PR has been sent to bors. t-logic Logic (model theory, set theory, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants