Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(Data/Polynomial/Expand): add leadingCoeff_expand and monic_expand_iff #9261

Closed
wants to merge 2 commits into from

Conversation

acmepjz
Copy link
Collaborator

@acmepjz acmepjz commented Dec 24, 2023

The first states that expand preserves leading coefficient; the second states that expand preserves monicity, hence gives a converse to Monic.expand.


Split from #9041, existing discussions: #9041 (comment) #9041 (comment)

Open in Gitpod

@acmepjz acmepjz added awaiting-review The author would like community review of the PR awaiting-CI t-algebra Algebra (groups, rings, fields etc) labels Dec 24, 2023
@acmepjz acmepjz added the easy < 20s of review time. See the lifecycle page for guidelines. label Dec 24, 2023
Mathlib/Data/Polynomial/Expand.lean Outdated Show resolved Hide resolved
Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
maintainer merge

Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Dec 25, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 25, 2023
…pand_iff` (#9261)

The first states that `expand` preserves leading coefficient; the second states that `expand` preserves monicity, hence gives a converse to `Monic.expand`.
@mathlib-bors
Copy link

mathlib-bors bot commented Dec 25, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Data/Polynomial/Expand): add leadingCoeff_expand and monic_expand_iff [Merged by Bors] - feat(Data/Polynomial/Expand): add leadingCoeff_expand and monic_expand_iff Dec 25, 2023
@mathlib-bors mathlib-bors bot closed this Dec 25, 2023
@mathlib-bors mathlib-bors bot deleted the acmepjz_monic_expand branch December 25, 2023 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants