Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: relative versions of equicontinuity #9286

Closed
wants to merge 37 commits into from
Closed

[Merged by Bors] - feat: relative versions of equicontinuity #9286

wants to merge 37 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Dec 26, 2023 •
edited by Parcly-Taxel

@ADedecker ADedecker added WIP Work in progress t-topology Topological spaces, uniform spaces, metric spaces, filters labels Dec 26, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-math-PR This PR depends on another PR to Mathlib label Dec 26, 2023
@ADedecker ADedecker mentioned this pull request Dec 26, 2023
Closed
5 tasks
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jan 30, 2024
@ADedecker ADedecker added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 30, 2024
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 31, 2024
sgouezel
sgouezel reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
Mathlib/Topology/UniformSpace/Equicontinuity.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jan 31, 2024
ADedecker and others added 3 commits January 31, 2024 18:55
@ADedecker @sgouezel
Apply suggestions from code review
41ea5b3 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@ADedecker
More suggestions from review
bf6c307
@ADedecker
Long line
74683a6
@ADedecker ADedecker added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jan 31, 2024
@sgouezel
Copy link
Contributor

sgouezel commented Feb 2, 2024

bors d+
(Do as you prefer on the closure vs closure' business, but maybe add some comment explaining the design).
Thanks!

@mathlib-bors
Copy link

mathlib-bors bot commented Feb 2, 2024

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels Feb 2, 2024
@ADedecker
Copy link
Member Author

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 2, 2024
mathlib-bors bot pushed a commit that referenced this pull request Feb 2, 2024
@ADedecker @hrmacbeth
feat: relative versions of equicontinuity (#9286)
935c079 
- [x] depends on: #7568



Co-authored-by: Heather Macbeth <25316162+hrmacbeth@users.noreply.github.com>
@mathlib-bors
Copy link

mathlib-bors bot commented Feb 2, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat: relative versions of equicontinuity [Merged by Bors] - feat: relative versions of equicontinuity Feb 2, 2024
@mathlib-bors mathlib-bors bot closed this Feb 2, 2024
@mathlib-bors mathlib-bors bot deleted the AD_equicontinuous_on branch February 2, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel sgouezel left review comments

Assignees
No one assigned
Labels
delegated ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ADedecker @leanprover-community-mathlib4-bot @sgouezel @hrmacbeth